Skip to content

Conversation

@Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Nov 22, 2025

Motivation and Context

Im reading the code base and finding some redundant lines.

StreamableHttpTransport and InMemoryTransport both extends BaseTransport. The BaseTransport already uses ManagesTransportCallbacks and implements an empty initialize() method.

How Has This Been Tested?

Not at all.

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Minor code clean up

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@chr-hertel chr-hertel merged commit 59ab088 into modelcontextprotocol:main Nov 22, 2025
10 checks passed
@chr-hertel
Copy link
Member

Good catch, thanks!

@Nyholm
Copy link
Contributor Author

Nyholm commented Nov 22, 2025

Thank you for merging

@Nyholm Nyholm deleted the redundant branch November 22, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants